CB-5645 [EE\AWS] Change the instruction in the Version update tab #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnaumov
requested changes
Oct 23, 2024
| * Licensed under the Apache License, Version 2.0. | ||
| * you may not use this file except in compliance with the License. | ||
| */ | ||
| export class GithubLinks { |
There was a problem hiding this comment.
Seems like its all static, we could convert it to const and function
|
|
||
| import type { InstructionComponent } from './VersionUpdateService.js'; | ||
|
|
||
| const SPLITTER = '*splitter*'; |
There was a problem hiding this comment.
This splitter is confusing, why do we need it? Can we use \n or translate args?
There was a problem hiding this comment.
split to 2 locale keys. the best we can do here
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "@cloudbeaver/core-website", | |||
There was a problem hiding this comment.
Why do we need to rename the package? I think both has the similar meaning
There was a problem hiding this comment.
it was about our website dbeaver.com, but now I can see it can be any links we have: website, github, social media, marketplaces etc. so left it as it is right now
devnaumov
approved these changes
Oct 23, 2024
…e-version-update-tab
…e-version-update-tab
…e-version-update-tab
This reverts commit 6c53b90.
…e-version-update-tab
Wroud
deleted the
CB-5645-ee-aws-change-the-instruction-in-the-version-update-tab
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.