-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: go1.20 and golangci-lint v1.55.2 #480
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey name Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
==========================================
+ Coverage 69.83% 70.08% +0.24%
==========================================
Files 35 35
Lines 2841 2841
==========================================
+ Hits 1984 1991 +7
+ Misses 743 738 -5
+ Partials 114 112 -2 ☔ View full report in Codecov by Sentry. |
…ssertions Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
mikeee
changed the title
Bump to go1.21.5 and golangci-lint v1.55.2
Bump to go1.20 and golangci-lint v1.55.2
Dec 7, 2023
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
…ethod Signed-off-by: mikeee <[email protected]>
mikeee
changed the title
Bump to go1.20 and golangci-lint v1.55.2
feat: go1.20 and golangci-lint v1.55.2
Dec 8, 2023
daixiang0
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mikeee
added a commit
to mikeee/dapr_go-sdk
that referenced
this pull request
Dec 17, 2023
* fix: remove invalid 'unused' config and fix wsl trailing whitespace key name Signed-off-by: mikeee <[email protected]> * fix: disable inamedparam linter Signed-off-by: mikeee <[email protected]> * fix: update package and tool to go1.21.5 Signed-off-by: mikeee <[email protected]> * fix: correct majority of the testifylinter issues relating to error assertions Signed-off-by: mikeee <[email protected]> * fix: reverse actual and expected values Signed-off-by: mikeee <[email protected]> * fix: correct test cases Signed-off-by: mikeee <[email protected]> * fix: correct misspell - upsert Signed-off-by: mikeee <[email protected]> * fix: add missing import Signed-off-by: mikeee <[email protected]> * update: bump validation workflow to 1.21 Signed-off-by: mikeee <[email protected]> * fix: refactor direct access references to proto fields Signed-off-by: mikeee <[email protected]> * fix: revert to go1.20 retaining version-1 support Signed-off-by: mikeee <[email protected]> * fix: update test-dapr-bot workflow golangci-lint ver to 1.55.2 Signed-off-by: mikeee <[email protected]> * fix: fix assertions for dapr-bot and check-lint-version Signed-off-by: mikeee <[email protected]> * fix: remove length function call Signed-off-by: mikeee <[email protected]> * fix: fix StateConsistency logic and add tests to satisfy codecov Signed-off-by: mikeee <[email protected]> * tests: add coverage of empty store names for delete bulk state item method Signed-off-by: mikeee <[email protected]> --------- Signed-off-by: mikeee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings the package up to go1.20
golangci-lint has been bumped from v1.54.2 to v1.55.2