Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: go1.20 and golangci-lint v1.55.2 #480

Merged
merged 16 commits into from
Dec 11, 2023

Conversation

mikeee
Copy link
Member

@mikeee mikeee commented Dec 6, 2023

Brings the package up to go1.20

golangci-lint has been bumped from v1.54.2 to v1.55.2

@mikeee mikeee requested a review from a team as a code owner December 6, 2023 16:20
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (959de75) 69.83% compared to head (335bcd9) 70.08%.

Files Patch % Lines
client/metadata.go 18.51% 18 Missing and 4 partials ⚠️
service/grpc/topic.go 80.95% 3 Missing and 1 partial ⚠️
service/grpc/invoke.go 66.66% 2 Missing and 1 partial ⚠️
client/crypto.go 33.33% 1 Missing and 1 partial ⚠️
client/actor.go 50.00% 1 Missing ⚠️
client/configuration.go 90.90% 0 Missing and 1 partial ⚠️
client/pubsub.go 88.88% 1 Missing ⚠️
service/grpc/binding.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
+ Coverage   69.83%   70.08%   +0.24%     
==========================================
  Files          35       35              
  Lines        2841     2841              
==========================================
+ Hits         1984     1991       +7     
+ Misses        743      738       -5     
+ Partials      114      112       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikeee mikeee marked this pull request as draft December 6, 2023 16:30
@mikeee mikeee changed the title Bump to go1.21.5 and golangci-lint v1.55.2 Bump to go1.20 and golangci-lint v1.55.2 Dec 7, 2023
@mikeee mikeee marked this pull request as ready for review December 7, 2023 19:48
@mikeee mikeee changed the title Bump to go1.20 and golangci-lint v1.55.2 feat: go1.20 and golangci-lint v1.55.2 Dec 8, 2023
Copy link
Member

@daixiang0 daixiang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daixiang0 daixiang0 merged commit 04f7b59 into dapr:main Dec 11, 2023
11 checks passed
@mikeee mikeee deleted the mikeee-upgrade-go-and-linters branch December 11, 2023 12:57
mikeee added a commit to mikeee/dapr_go-sdk that referenced this pull request Dec 17, 2023
* fix: remove invalid 'unused' config and fix wsl trailing whitespace key name

Signed-off-by: mikeee <[email protected]>

* fix: disable inamedparam linter

Signed-off-by: mikeee <[email protected]>

* fix: update package and tool to go1.21.5

Signed-off-by: mikeee <[email protected]>

* fix: correct majority of the testifylinter issues relating to error assertions

Signed-off-by: mikeee <[email protected]>

* fix: reverse actual and expected values

Signed-off-by: mikeee <[email protected]>

* fix: correct test cases

Signed-off-by: mikeee <[email protected]>

* fix: correct misspell - upsert

Signed-off-by: mikeee <[email protected]>

* fix: add missing import

Signed-off-by: mikeee <[email protected]>

* update: bump validation workflow to 1.21

Signed-off-by: mikeee <[email protected]>

* fix: refactor direct access references to proto fields

Signed-off-by: mikeee <[email protected]>

* fix: revert to go1.20 retaining version-1 support

Signed-off-by: mikeee <[email protected]>

* fix: update test-dapr-bot workflow golangci-lint ver to 1.55.2

Signed-off-by: mikeee <[email protected]>

* fix: fix assertions for dapr-bot and check-lint-version

Signed-off-by: mikeee <[email protected]>

* fix: remove length function call

Signed-off-by: mikeee <[email protected]>

* fix: fix StateConsistency logic and add tests to satisfy codecov

Signed-off-by: mikeee <[email protected]>

* tests: add coverage of empty store names for delete bulk state item method

Signed-off-by: mikeee <[email protected]>

---------

Signed-off-by: mikeee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants