fix: update StateConsistency type to match protobufs #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #481 +/- ##
==========================================
+ Coverage 70.08% 70.26% +0.18%
==========================================
Files 35 35
Lines 2841 2859 +18
==========================================
+ Hits 1991 2009 +18
Misses 738 738
Partials 112 112 ☔ View full report in Codecov by Sentry. |
daixiang0
reviewed
Dec 11, 2023
mikeee
force-pushed
the
mikeee-fix-stateconsistency-type
branch
from
152ae88 to
61158e8
Compare
Signed-off-by: mikeee <[email protected]>
daixiang0
reviewed
Jan 8, 2024
|
Looks like I accidentally committed this to #480 and it was merged. With the latest it implements the recommendations and further unit tests. |
Signed-off-by: mikeee <[email protected]>
yaron2
approved these changes
Jan 19, 2024
mikeee
added a commit
to mikeee/dapr_go-sdk
that referenced
this pull request
Jan 19, 2024
* fix: correct state consistency types Signed-off-by: mikeee <[email protected]> * fix: add tests to type conversions Signed-off-by: mikeee <[email protected]> --------- Signed-off-by: mikeee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes StateConsistency type to match protobufs, at the moment returns undefined for everything due to the logic.
https://github.com/dapr/dapr/blob/ed3417223c5ea4654f38df1fc5abee93e52cea6e/dapr/proto/common/v1/common.proto#L140