add note on unsubscribeConfiguration being deprecated #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cassandra Coyle <[email protected]>
yaron2
previously approved these changes
Sep 22, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #457 +/- ##
=======================================
Coverage 69.17% 69.17%
=======================================
Files 34 34
Lines 2735 2735
=======================================
Hits 1892 1892
Misses 734 734
Partials 109 109
☔ View full report in Codecov by Sentry. |
2 tasks
JoshVanL
suggested changes
Sep 24, 2023
Co-authored-by: Josh van Leeuwen <[email protected]> Signed-off-by: Cassie Coyle <[email protected]>
mikeee
pushed a commit
to mikeee/dapr_go-sdk
that referenced
this pull request
Nov 13, 2023
* add note on unsubscribeConfiguration being deprecated Signed-off-by: Cassandra Coyle <[email protected]> * Update client/client.go Co-authored-by: Josh van Leeuwen <[email protected]> Signed-off-by: Cassie Coyle <[email protected]> --------- Signed-off-by: Cassandra Coyle <[email protected]> Signed-off-by: Cassie Coyle <[email protected]> Co-authored-by: Josh van Leeuwen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly noting a deprecated function to make it more obvious to end users. Suggestions to wording it differently are welcomed.