Skip to content

Commit

Permalink
add note on unsubscribeConfiguration being deprecated (dapr#457)
Browse files Browse the repository at this point in the history
* add note on unsubscribeConfiguration being deprecated

Signed-off-by: Cassandra Coyle <[email protected]>

* Update client/client.go

Co-authored-by: Josh van Leeuwen <[email protected]>
Signed-off-by: Cassie Coyle <[email protected]>

---------

Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassie Coyle <[email protected]>
Co-authored-by: Josh van Leeuwen <[email protected]>
  • Loading branch information
2 people authored and mikeee committed Nov 13, 2023
1 parent a27e3dc commit f00b3ad
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,8 @@ type Client interface {
// SubscribeConfigurationItems can subscribe the change of configuration items by storeName and keys, and return subscription id
SubscribeConfigurationItems(ctx context.Context, storeName string, keys []string, handler ConfigurationHandleFunction, opts ...ConfigurationOpt) (string, error)

// UnsubscribeConfigurationItems stops the subscription with target store's and ID.
// Deprecated: Closing the `SubscribeConfigurationItems` stream (closing the given context) will unsubscribe the client and should be used in favor of `UnsubscribeConfigurationItems`.
// UnsubscribeConfigurationItems can stop the subscription with target store's and id
UnsubscribeConfigurationItems(ctx context.Context, storeName string, id string, opts ...ConfigurationOpt) error

Expand Down

0 comments on commit f00b3ad

Please sign in to comment.