Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rm superfluous header on actor example #444

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: rm superfluous header on actor example #444

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
116d65a
fix: rm superfluous header
sicoyle Sep 8, 2023
0c6cce8
fix: add returns
sicoyle Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions service/http/topic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,11 @@
err := runtime.GetActorRuntimeInstanceContext().Deactivate(r.Context(), actorType, actorID)
if err == actorErr.ErrActorTypeNotFound || err == actorErr.ErrActorIDNotFound {
w.WriteHeader(http.StatusNotFound)
return
}
if err != actorErr.Success {
w.WriteHeader(http.StatusInternalServerError)
return

Check warning on line 182 in service/http/topic.go

View check run for this annotation

Codecov / codecov/patch

service/http/topic.go#L182 

Added line #L182 was not covered by tests
}
w.WriteHeader(http.StatusOK)
}
Expand All @@ -192,12 +194,15 @@
err := runtime.GetActorRuntimeInstanceContext().InvokeReminder(r.Context(), actorType, actorID, reminderName, reqData)
if err == actorErr.ErrActorTypeNotFound {
w.WriteHeader(http.StatusNotFound)
return
}
if err != actorErr.Success {
w.WriteHeader(http.StatusInternalServerError)
return
}
w.WriteHeader(http.StatusOK)
}

s.mux.Put("/actors/{actorType}/{actorId}/method/remind/{reminderName}", fReminder)

// register actor timer invoke handler
Expand All @@ -209,9 +214,11 @@
err := runtime.GetActorRuntimeInstanceContext().InvokeTimer(r.Context(), actorType, actorID, timerName, reqData)
if err == actorErr.ErrActorTypeNotFound {
w.WriteHeader(http.StatusNotFound)
return
}
if err != actorErr.Success {
w.WriteHeader(http.StatusInternalServerError)
return
}
w.WriteHeader(http.StatusOK)
}
Expand Down
Loading