-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rm superfluous header on actor example #444
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Samantha Coyle <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #444 +/- ##
==========================================
- Coverage 70.00% 69.09% -0.91%
==========================================
Files 33 34 +1
Lines 2667 2741 +74
==========================================
+ Hits 1867 1894 +27
- Misses 698 737 +39
- Partials 102 110 +8
☔ View full report in Codecov by Sentry. |
We still need the write header line that was removed, because it accounts for a situation where there's no error. What needs to be done is to add a |
ping @sicoyle |
Signed-off-by: Samantha Coyle <[email protected]>
pong @yaron2 😄 |
Could we add a test for it? |
Hi @daixiang0 @sicoyle , can this be merged asap please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Similar to:
#218
There is a superfluous header call show in the actors example:
With the removal of the line in this PR, the superflous header is removed: