Fix tests in a more pytonic way as proposed by @dlax

dalibo · Aug 21, 2023 · 01087de · 01087de
1 parent 28bbfe9
commit 01087de
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/check_patroni/types.py b/check_patroni/types.py
@@ -69,7 +69,10 @@ def rest_api(self: "PatroniResource", service: str) -> Any:
                     f"Failed to connect to {endpoint}/{service} status code {r.status_code}"
                 )
 
-            return r.json() if r.text else None
+            try:
+                return r.json()
+            except requests.exceptions.JSONDecodeError:
+                return None
         raise nagiosplugin.CheckError("Connection failed for all provided endpoints")