Fix liveness check

The liveness probe used to return something. It looks like it doesn't do
it anymore and it breaks the `node_is_alive` check.

Issue: #31

check_patroni/types.py

@@ -60,14 +60,16 @@ def rest_api(self: "PatroniResource", service: str) -> Any:
                 _log.debug(e)
                 continue
             # The status code is already displayed by urllib3
-            _log.debug("api call data: %(data)s", {"data": r.text})
+            _log.debug(
+                "api call data: %(data)s", {"data": r.text if r.text else "<Empty>"}
+            )
 
             if r.status_code != 200:
                 raise APIError(
                     f"Failed to connect to {endpoint}/{service} status code {r.status_code}"
                 )
 
-            return r.json()
+            return r.json() if r.text else None
         raise nagiosplugin.CheckError("Connection failed for all provided endpoints")
 
 

tests/test_node_is_alive.py

@@ -9,14 +9,14 @@
 def test_node_is_alive_ok(mocker: MockerFixture) -> None:
     runner = CliRunner()
 
-    my_mock(mocker, "node_is_alive", 200)
+    my_mock(mocker, None, 200)
     result = runner.invoke(main, ["-e", "https://10.20.199.3:8008", "node_is_alive"])
     assert result.exit_code == 0
 
 
 def test_node_is_alive_ko(mocker: MockerFixture) -> None:
     runner = CliRunner()
 
-    my_mock(mocker, "node_is_alive", 404)
+    my_mock(mocker, None, 404)
     result = runner.invoke(main, ["-e", "https://10.20.199.3:8008", "node_is_alive"])
     assert result.exit_code == 2

tests/tools.py

@@ -22,7 +22,7 @@ def my_mock(mocker: MockerFixture, json_file: str, status: int) -> None:
     def mock_rest_api(self: PatroniResource, service: str) -> Any:
         if status != 200:
             raise APIError("Test en erreur pour status code 200")
-        return getjson(json_file)
+        return getjson(json_file) if json_file else None
 
     mocker.resetall()
     mocker.patch("check_patroni.types.PatroniResource.rest_api", mock_rest_api)