Bugfix/ota improvement #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Minor improvement to OTA update handling
WHY
If an OTA update is interrupted in certain ways, the onEnd callback will not be called as it should (there are reports of it in the source repo). The emulator gets stuck in update mode, and since updates are announced to the inverter it might sit there happily while not updating the SOC since we disable CAN to make the OTA update more robust.
See also
ayushsharma82/ElegantOTA#161
HOW
A timeout was added, or more like a watchdog. If the progress callback doesn't kick the watchdog, the OTA update event is cleared and the emulator attempts to restore CAN communication. Depending on the situation, the emulator will either reset or continue without any faults.
TESTING
Tested on the dining room table, will run live before merge if approved