Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTA update fault handling needs improvement #172

Closed
Cabooman opened this issue Feb 12, 2024 · 0 comments · Fixed by #175
Closed

OTA update fault handling needs improvement #172

Cabooman opened this issue Feb 12, 2024 · 0 comments · Fixed by #175
Labels
bug Something isn't working

Comments

@Cabooman
Copy link
Collaborator

Cabooman commented Feb 12, 2024

PROBLEM

When an OTA update fails for some reason, onOTAEnd() doesn't seem to be called, resulting in that we stay in an "updating" state with no CAN. The communicated state to the inverter is also UPDATING, so it's happy even though we're not updating any values from the battery BMS.

STEPS TO REPRODUCE

Start an OTA update, disconnect from wifi on the sending computer

PROPOSAL FOR SOLUTION

Implement an OTA timeout independent of the onOTAxxx functions, that restores CAN or performs a reset

@Cabooman Cabooman added the bug Something isn't working label Feb 12, 2024
@Cabooman Cabooman linked a pull request Feb 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant