Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBP-1012 setup loadtest env- First Merge to register GHA in repo, WIP ! #4

Merged
merged 6 commits into from
Oct 11, 2024

Conversation

MWesterholz
Copy link
Contributor

work in progress, merge might contain bugs. Must be merged to test GHA

@MWesterholz MWesterholz requested a review from aimee-889 October 11, 2024 11:29
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Contributor

@aimee-889 aimee-889 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjustments can be done after merging :)

uses: dBildungsplattform/dbp-github-workflows/.github/workflows/[email protected]
secrets: inherit
with:
chart_name: spsh-k6-loadtest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chart name is schulportal-load-tests

contents: read
uses: dBildungsplattform/dbp-github-workflows/.github/workflows/[email protected]
with:
image_name: "spsh-k6-loadtest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would also like the image name to change to the repo name: schulportal-load-tests

@@ -0,0 +1,5 @@
apiVersion: v1
name: spsh-load-test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plaese adjust name

on:
workflow_call:
inputs:
instance_name:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inputs need cleaning

@MWesterholz
Copy link
Contributor Author

naming adjusted according to review

@MWesterholz MWesterholz merged commit ccae28b into main Oct 11, 2024
3 of 4 checks passed
@MWesterholz MWesterholz deleted the DBP-10-12-setup-loadtest-env branch October 11, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants