Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spsh 1371 #20

Merged
merged 22 commits into from
Dec 10, 2024
Merged

Spsh 1371 #20

merged 22 commits into from
Dec 10, 2024

Conversation

clauyan
Copy link
Contributor

@clauyan clauyan commented Dec 5, 2024

Description

Links to Tickets or other PRs

Notes

Approval for review

  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@clauyan clauyan marked this pull request as ready for review December 5, 2024 16:01
@phaelcg phaelcg self-requested a review December 10, 2024 08:51
@@ -161,7 +161,7 @@ export function deleteTestUsers(ids: Array<string>) {
batch(
ids.map((id) => ({
method: "DELETE",
url: `${getBackendUrl()}personen/${id}`,
url: url`${getBackendUrl()}personen/${id}`,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ist die url, die Webseite Root? Falls ja, liefert getBackendUrl() nur den Subpath in der URL oder die gesammte URL?

@clauyan clauyan merged commit 61c46ef into main Dec 10, 2024
4 checks passed
@clauyan clauyan deleted the SPSH-1371 branch December 10, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants