Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: Add 3.10 support #4524

Merged
merged 1 commit into from
Aug 18, 2022
Merged

python: Add 3.10 support #4524

merged 1 commit into from
Aug 18, 2022

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Nov 19, 2021 •
edited
Loading

Add support for Python 3.10.

Note 3.11 is now nearing release but we can't install our deps with it just yet...

Note: We may need to change the conda-forge metadata for the 8.1.0 release.

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PRs raised to both master and the relevant maintenance branch.

@oliver-sanders oliver-sanders added this to the cylc-8.0rc1 milestone Nov 19, 2021
@oliver-sanders oliver-sanders self-assigned this Nov 19, 2021
@oliver-sanders oliver-sanders added the BLOCKED This can't happen until something else does label Nov 19, 2021
@oliver-sanders
Copy link
Member Author

Blocked by pyuv.

@ngam
Copy link

ngam commented Nov 19, 2021

Blocked by pyuv.

does adding libuv as req help?

@oliver-sanders
Copy link
Member Author

oliver-sanders commented Nov 22, 2021 •
edited
Loading

I think pyuv bundles its own libuv?

The issue is that pyuv needs some changes to the C code to work with "3.10".

conda-forge/pyuv-feedstock#12 (comment)

@dwsutherland
Copy link
Member

Relates to cylc/cylc-uiserver#260

(perhaps why you're upgrading?)

@hjoliver hjoliver modified the milestones: cylc-8.0rc1, cylc-8.0.0 Nov 30, 2021
@oliver-sanders
Copy link
Member Author

This issue could potentially remove our dependency of pyuv - #4601

@oliver-sanders oliver-sanders modified the milestones: cylc-8.0.0, cylc-8.x Feb 15, 2022
@oliver-sanders oliver-sanders mentioned this pull request Jul 22, 2022
Closed
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this pull request Jul 29, 2022
@oliver-sanders
scan: switch from pyuv to os.listdir in asyncio executor
424d53c 
* We were using pyuv to perform directory listing.
* Unfortunately pyuv is no longer actively maintained.
* Switching to the simpler method of running `os.listdir` in an executor
  ala aiofiles.
* Unblocks cylc#4524
@oliver-sanders oliver-sanders modified the milestones: cylc-8.x, cylc-8.1.0 Jul 29, 2022
@oliver-sanders oliver-sanders mentioned this pull request Jul 29, 2022
Merged
7 tasks
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this pull request Aug 1, 2022
@oliver-sanders
scan: switch from pyuv to os.listdir in asyncio executor
04fa53e 
* We were using pyuv to perform directory listing.
* Unfortunately pyuv is no longer actively maintained.
* Switching to the simpler method of running `os.listdir` in an executor
  ala aiofiles.
* Unblocks cylc#4524
wxtim pushed a commit that referenced this pull request Aug 8, 2022
@oliver-sanders
scan: switch from pyuv to os.listdir in asyncio executor (#5028)
b04fb77 
* We were using pyuv to perform directory listing.
* Unfortunately pyuv is no longer actively maintained.
* Switching to the simpler method of running `os.listdir` in an executor
  ala aiofiles.
* Unblocks #4524
@wxtim wxtim removed the BLOCKED This can't happen until something else does label Aug 8, 2022
@oliver-sanders
Copy link
Member Author

The pyuv dependency has now been dropped so we can press ahead with this.

@oliver-sanders
Copy link
Member Author

Tried adding 3.11.dev to the fast_tests, however, installation failed - https://github.com/cylc/cylc-flow/runs/7723829198?check_suite_focus=true#step:6:734

Need to wait for our dependencies to release 3.11 wheels.

@oliver-sanders oliver-sanders marked this pull request as ready for review August 8, 2022 12:36
@hjoliver hjoliver added the BLOCKED This can't happen until something else does label Aug 9, 2022
@hjoliver
Copy link
Member

hjoliver commented Aug 9, 2022 •
edited
Loading

Need to wait for our dependencies to release 3.11 wheels.

I'll restore the blocked label for now.

@MetRonnie
Copy link
Member

it doesn't block us from 3.10 support though?

@hjoliver
Copy link
Member

Sorry, misread!

@hjoliver hjoliver removed the BLOCKED This can't happen until something else does label Aug 10, 2022
@oliver-sanders
Copy link
Member Author

oliver-sanders commented Aug 11, 2022 •
edited
Loading

(couple of random test failures [3.8], rebased to see if they return)

@MetRonnie MetRonnie self-requested a review August 11, 2022 10:12
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this pull request Aug 12, 2022
@oliver-sanders
scan: switch from pyuv to os.listdir in asyncio executor (cylc#5028)
2fb0f54 
* We were using pyuv to perform directory listing.
* Unfortunately pyuv is no longer actively maintained.
* Switching to the simpler method of running `os.listdir` in an executor
  ala aiofiles.
* Unblocks cylc#4524
@MetRonnie
Copy link
Member

Poking tests

@MetRonnie MetRonnie closed this Aug 12, 2022
@MetRonnie MetRonnie reopened this Aug 12, 2022
MetRonnie
MetRonnie approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. (Test failure is due to the flaky integration test situation)

oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this pull request Aug 15, 2022
@oliver-sanders
scan: switch from pyuv to os.listdir in asyncio executor (cylc#5028)
682ebba 
* We were using pyuv to perform directory listing.
* Unfortunately pyuv is no longer actively maintained.
* Switching to the simpler method of running `os.listdir` in an executor
  ala aiofiles.
* Unblocks cylc#4524
hjoliver pushed a commit to hjoliver/cylc-flow that referenced this pull request Aug 17, 2022
@oliver-sanders @hjoliver
scan: switch from pyuv to os.listdir in asyncio executor (cylc#5028)
f054778 
* We were using pyuv to perform directory listing.
* Unfortunately pyuv is no longer actively maintained.
* Switching to the simpler method of running `os.listdir` in an executor
  ala aiofiles.
* Unblocks cylc#4524
hjoliver pushed a commit to hjoliver/cylc-flow that referenced this pull request Aug 18, 2022
@oliver-sanders @hjoliver
scan: switch from pyuv to os.listdir in asyncio executor (cylc#5028)
64765da 
* We were using pyuv to perform directory listing.
* Unfortunately pyuv is no longer actively maintained.
* Switching to the simpler method of running `os.listdir` in an executor
  ala aiofiles.
* Unblocks cylc#4524
@MetRonnie
Copy link
Member

Changelog entry?

@oliver-sanders
Copy link
Member Author

I don't think we need a changelog for this metadata change caused by a dependency of a dependency, it's a bit meta.

@MetRonnie
Copy link
Member

Thought it might be nice to have "added support for Python 3.10" in the changelog

@oliver-sanders
Copy link
Member Author

We didn't really "add" it as much as unblock it, feel free to add if you think it's important.

hjoliver
hjoliver approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@hjoliver hjoliver merged commit 38475b4 into cylc:master Aug 18, 2022
@oliver-sanders oliver-sanders deleted the py-3.10 branch August 19, 2022 08:02
wxtim pushed a commit to wxtim/cylc that referenced this pull request Aug 26, 2022
@oliver-sanders @wxtim
scan: switch from pyuv to os.listdir in asyncio executor (cylc#5028)
9b8223b 
* We were using pyuv to perform directory listing.
* Unfortunately pyuv is no longer actively maintained.
* Switching to the simpler method of running `os.listdir` in an executor
  ala aiofiles.
* Unblocks cylc#4524
wxtim pushed a commit to wxtim/cylc that referenced this pull request Oct 3, 2022
@oliver-sanders @wxtim
scan: switch from pyuv to os.listdir in asyncio executor (cylc#5028)
495a6f5 
* We were using pyuv to perform directory listing.
* Unfortunately pyuv is no longer actively maintained.
* Switching to the simpler method of running `os.listdir` in an executor
  ala aiofiles.
* Unblocks cylc#4524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie MetRonnie approved these changes

@hjoliver hjoliver hjoliver approved these changes

@wxtim wxtim Awaiting requested review from wxtim

Assignees

@oliver-sanders oliver-sanders

Labels
None yet
Projects
None yet
Milestone
cylc-8.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@oliver-sanders @ngam @dwsutherland @hjoliver @MetRonnie @wxtim