Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scan: switch from pyuv to os.listdir in asyncio executor #5028

Merged
merged 1 commit into from
Aug 8, 2022
Merged

scan: switch from pyuv to os.listdir in asyncio executor #5028

merged 1 commit into from
Aug 8, 2022

Conversation

oliver-sanders
Copy link
Member

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Does not need tests (why?).
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required.

@oliver-sanders oliver-sanders added this to the cylc-8.1.0 milestone Jul 29, 2022
@oliver-sanders oliver-sanders self-assigned this Jul 29, 2022
@oliver-sanders
scan: switch from pyuv to os.listdir in asyncio executor
04fa53e 
* We were using pyuv to perform directory listing.
* Unfortunately pyuv is no longer actively maintained.
* Switching to the simpler method of running `os.listdir` in an executor
  ala aiofiles.
* Unblocks cylc#4524
@wxtim
Copy link
Member

wxtim commented Aug 8, 2022 •
edited
Loading

  • Read and understood PR
  • Tried it locally - worked fine.
  • Still failing some tests, the integration test looks fine locally, so I'm hoping it's nothing serious. The manylinux compatibility test failing on the older Ubuntus looks more concerning.

@wxtim wxtim merged commit b04fb77 into cylc:master Aug 8, 2022
@oliver-sanders oliver-sanders deleted the remove-pyuv-dependency branch August 8, 2022 12:34
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this pull request Aug 12, 2022
@oliver-sanders
scan: switch from pyuv to os.listdir in asyncio executor (cylc#5028)
2fb0f54 
* We were using pyuv to perform directory listing.
* Unfortunately pyuv is no longer actively maintained.
* Switching to the simpler method of running `os.listdir` in an executor
  ala aiofiles.
* Unblocks cylc#4524
@oliver-sanders oliver-sanders mentioned this pull request Aug 12, 2022
Merged
8 tasks
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this pull request Aug 15, 2022
@oliver-sanders
scan: switch from pyuv to os.listdir in asyncio executor (cylc#5028)
682ebba 
* We were using pyuv to perform directory listing.
* Unfortunately pyuv is no longer actively maintained.
* Switching to the simpler method of running `os.listdir` in an executor
  ala aiofiles.
* Unblocks cylc#4524
hjoliver pushed a commit to hjoliver/cylc-flow that referenced this pull request Aug 17, 2022
@oliver-sanders @hjoliver
scan: switch from pyuv to os.listdir in asyncio executor (cylc#5028)
f054778 
* We were using pyuv to perform directory listing.
* Unfortunately pyuv is no longer actively maintained.
* Switching to the simpler method of running `os.listdir` in an executor
  ala aiofiles.
* Unblocks cylc#4524
@MetRonnie MetRonnie mentioned this pull request Aug 17, 2022
Closed
8 tasks
hjoliver pushed a commit to hjoliver/cylc-flow that referenced this pull request Aug 18, 2022
@oliver-sanders @hjoliver
scan: switch from pyuv to os.listdir in asyncio executor (cylc#5028)
64765da 
* We were using pyuv to perform directory listing.
* Unfortunately pyuv is no longer actively maintained.
* Switching to the simpler method of running `os.listdir` in an executor
  ala aiofiles.
* Unblocks cylc#4524
@MetRonnie MetRonnie mentioned this pull request Aug 18, 2022
Merged
8 tasks
wxtim pushed a commit to wxtim/cylc that referenced this pull request Aug 26, 2022
@oliver-sanders @wxtim
scan: switch from pyuv to os.listdir in asyncio executor (cylc#5028)
9b8223b 
* We were using pyuv to perform directory listing.
* Unfortunately pyuv is no longer actively maintained.
* Switching to the simpler method of running `os.listdir` in an executor
  ala aiofiles.
* Unblocks cylc#4524
wxtim pushed a commit to wxtim/cylc that referenced this pull request Oct 3, 2022
@oliver-sanders @wxtim
scan: switch from pyuv to os.listdir in asyncio executor (cylc#5028)
495a6f5 
* We were using pyuv to perform directory listing.
* Unfortunately pyuv is no longer actively maintained.
* Switching to the simpler method of running `os.listdir` in an executor
  ala aiofiles.
* Unblocks cylc#4524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxtim wxtim wxtim approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
None yet
Projects
None yet
Milestone
cylc-8.1.0
Development

Successfully merging this pull request may close these issues.

remove pyuv dependency 😢
2 participants
@oliver-sanders @wxtim