余白追加_調整予定 #50
Merged
余白追加_調整予定 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/app/page.tsx
Outdated
Comment on lines
7
to
12
| style={{ | ||
| display: 'flex', | ||
| justifyContent: 'space-evenly', | ||
| marginLeft: '5%', | ||
| marginRight: '5%', | ||
| width: '100%', |
There was a problem hiding this comment.
StyledComponent使ってください。
キャプションとマイルストーン以外のコンテンツが今後はいる可能性もあるので拡張性を持たせるためにrightcolumn leftcolumnみたいな感じで中身の要素ももう一つ箱作ってあげるイメージでレイアウト整えると後で楽だと思います。
AyumuAkimoto
reviewed
Oct 6, 2023
src/app/page.tsx
Outdated
Comment on lines
28
to
34
| display: row; | ||
| justify-content: flex-start; | ||
| max-width: 580px; | ||
| `; | ||
|
|
||
| const RightColumn = styled('div')` | ||
| display: row; |
There was a problem hiding this comment.
LeftColumn と RightColumn の display プロパティが 'row' に設定されていますが、実際のCSSでは 'row' という値は存在しません。おそらく 'flex' または 'block' といった適切な値を設定する必要があります。
ってチャットGPT が言ってたので調べてみたけどそうっぽい。
AyumuAkimoto
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
変更内容
位置調整に余白とかおいてみた