Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .tif format #117 #118

Closed
wants to merge 1 commit into from
Closed

Add .tif format #117 #118

wants to merge 1 commit into from

Conversation

geekdenz
Copy link

No description provided.

@dbouron
Copy link
Contributor

dbouron commented Mar 24, 2022

Hello @geekdenz,
Thank you for enhancing this project. In fact, you cannot enable the tiff format only though this enum.
You have to integrate the libtiff library into the build system.
I will try to have a closer look this week end on how libvips use this library.
A good pointer to check what libtiff needs is to take a look on the build-win64 config file.

@geekdenz
Copy link
Author

Thanks for your quick reply @dbouron !

I believe when you install the library Vips on Linux with apt-get install libvips42 it might have tif support already. Otherwise, wouldn't there be an easy apt-get install <package> that can be installed to enable that?

@geekdenz
Copy link
Author

The first example here:
https://www.libvips.org/API/current/file-format.html
uses tif. Am I missing something?

@geekdenz
Copy link
Author

Just ran it on this example with no problem:
image

Command:
vips invert sample_1280×853.tiff inverted.tif

@dbouron
Copy link
Contributor

dbouron commented Mar 27, 2022

I believe when you install the library Vips on Linux with apt-get install libvips42 it might have tif support already. Otherwise, wouldn't there be an easy apt-get install <package> that can be installed to enable that?

Yes, you are right if you have a minimal build of JVips. It will not build external dependencies and use the ones installed on the system.
But we have to specify how to build and link libtiff to libvips for the jar build with embedded libraries.

@dbouron
Copy link
Contributor

dbouron commented Mar 27, 2022

Hi,
I did this PR for the tiff support. I will merge tomorrow if the main build workflow passed :)
Feel free to review / comment my commit before merging.

@dbouron
Copy link
Contributor

dbouron commented Apr 5, 2022

I just merged #119. Closing this PR

@dbouron dbouron closed this Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants