Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all supported image formats #117

Open
geekdenz opened this issue Mar 16, 2022 · 1 comment
Open

Add all supported image formats #117

geekdenz opened this issue Mar 16, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@geekdenz
Copy link

Vips supports at least also ".tif":

https://github.com/libvips/libvips/blob/v8.9.1/test/test-suite/test_foreign.py#L304-L317

Could you support that as well? Should be a trivial change here:

https://github.com/criteo/JVips/blob/master/src/main/java/com/criteo/vips/enums/VipsImageFormat.java#L24

Add:

TIF(".tif"),

I could do a PR but that might take me longer than for you to do the change and supply a new version.

Many thanks for this awesome wrapper for this amazing library!

geekdenz added a commit to geekdenz/JVips that referenced this issue Mar 16, 2022
@dbouron
Copy link
Contributor

dbouron commented Mar 24, 2022

Hello @geekdenz,

I just answered in your PR, this is not trivial like adding the enum value. I provided more explanations in comment .

If I have free time this week end, I will have a look :)

@dbouron dbouron added the enhancement New feature or request label Mar 24, 2022
dbouron added a commit that referenced this issue Mar 27, 2022
See this issue: #117
dbouron added a commit that referenced this issue Mar 28, 2022
See this issue: #117
dbouron added a commit that referenced this issue Apr 5, 2022
See this issue: #117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants