Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): node 20.9.0 lts #1337

Merged
merged 4 commits into from
Oct 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/e2e-run/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ runs:
- uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3
with:
cache: 'npm'
node-version: ${{inputs.node}}
node-version-file: '.nvmrc'
- uses: actions/setup-python@57ded4d7d5e986d7296eab16560982c6dd7c923b # v4
with:
cache: 'pip'
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20.8.0
20.9.0
2 changes: 1 addition & 1 deletion packages/cli/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"author": "Coveo",
"description": "Coveo CLI",
"engines": {
"node": "^18.18.1 || ^20.8.1"
"node": "^18.18.1 || ^20.9.0"
},
"dependencies": {
"@amplitude/analytics-node": "^1.3.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/core/src/commands/ui/create/angular.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export default class Angular extends CLICommand {
* Requirements Based on https://angular.io/guide/setup-local
* and https://www.npmjs.com/package/@angular/cli package.json engines section.
*/
public static requiredNodeVersion = '^18.18.1 || ^20.8.1';
public static requiredNodeVersion = '^18.18.1 || ^20.9.0';
public static requiredNpmVersion = '^9.8.1 || ^10.1.0';
public static requiredNgVersion = '^15.0.0';

Expand Down
2 changes: 1 addition & 1 deletion packages/cli/core/src/commands/ui/create/react.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export default class React extends CLICommand {
* "You’ll need to have Node 18.18.1 or later version on your local development machine"
* https://github.com/facebook/create-react-app#creating-an-app
*/
public static requiredNodeVersion = '^18.18.1 || ^20.8.1';
public static requiredNodeVersion = '^18.18.1 || ^20.9.0';

public static description =
'Create a Coveo Headless-powered search page with the React web framework. See <https://docs.coveo.com/headless> and <https://reactjs.org/>.';
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/core/src/commands/ui/create/vue.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export default class Vue extends CLICommand {
* @see https://cli.vuejs.org/guide/installation.html for current requirements.
* @see https://github.com/vuejs/vue-cli/blob/dev/CHANGELOG.md for upcoming requirements.
*/
public static requiredNodeVersion = '^18.18.1 || ^20.8.1';
public static requiredNodeVersion = '^18.18.1 || ^20.9.0';
public static description =
'Create a Coveo Headless-powered search page with the Vue3 and Vite. See <https://docs.coveo.com/headless> and <https://vuejs.org/>.';

Expand Down
2 changes: 1 addition & 1 deletion packages/cli/core/src/lib/atomic/createAtomicProject.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export const atomicAppInitializerPackage = '@coveo/create-atomic';
export const atomicLibInitializerPackage =
'@coveo/create-atomic-component-project';

const supportedNodeVersions = '^18.18.1 || ^20.8.1';
const supportedNodeVersions = '^18.18.1 || ^20.9.0';

const transformPackageNameToNpmInitializer = (packageName: string) =>
packageName.replace('/create-', '/');
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/source/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
"prepublishOnly": "rimraf lib && npm run build && oclif manifest"
},
"engines": {
"node": "^18.18.1 || ^20.8.1"
"node": "^18.18.1 || ^20.9.0"
},
"bugs": "https://github.com/coveo/cli/issues",
"keywords": [
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/cra-template/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
},
"license": "Apache-2.0",
"engines": {
"node": "^18.18.1 || ^20.8.1"
"node": "^18.18.1 || ^20.9.0"
},
"files": [
"template",
Expand Down