Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): node 20.9.0 lts #1337

Merged
merged 4 commits into from
Oct 25, 2023
Merged

feat(cli): node 20.9.0 lts #1337

merged 4 commits into from
Oct 25, 2023

Conversation

olamothe
Copy link
Member

@olamothe olamothe requested a review from a team as a code owner October 24, 2023 19:59
@olamothe olamothe requested review from y-lakhdar, louis-bompart and dmbrooke and removed request for a team October 24, 2023 19:59
@github-actions
Copy link
Contributor

Thanks for your contribution @olamothe !
When your pull-request is ready to be merged, check the box below to merge it

  • Merge! :shipit:

@olamothe olamothe enabled auto-merge (squash) October 24, 2023 20:00
louis-bompart
louis-bompart approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind the suggestions tho

packages/cli/core/src/commands/ui/create/angular.ts Outdated Show resolved Hide resolved
packages/cli/core/package.json Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

@olamothe olamothe merged commit af1c3ac into master Oct 25, 2023
47 checks passed
@olamothe olamothe deleted the CDX-1495 branch October 25, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbrooke dmbrooke dmbrooke approved these changes

@louis-bompart louis-bompart louis-bompart approved these changes

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olamothe @louis-bompart @dmbrooke