Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test containers: add systemd to tang image #3983

Merged
merged 1 commit into from
Dec 4, 2024
Merged

test containers: add systemd to tang image #3983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/containers/tang/Containerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM registry.fedoraproject.org/fedora-minimal:41
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would switching to the non-minimal image here be a better move? i.e. would less rpms get downloaded in the dnf install below?

Copy link
Contributor Author

@jbtrystram jbtrystram Dec 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not enough to fix this issue though, systemd is not in the non-minimal image either. So I'd rather stick with the smaller image


RUN dnf -y install tang && dnf clean all && rm -rf /var/cache/yum
RUN dnf -y install systemd tang && dnf clean all && rm -rf /var/cache/yum
EXPOSE 80

RUN systemctl enable tangd.socket
Expand Down
Loading