test containers: add systemd to tang image #3983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the F41 fedora-minimal image, systemctl stopped working. We need to enable tang.service in the container so we need systemd in the container. Adding systemd in the container.
travier
approved these changes
Dec 4, 2024
Do you mean that systemd was removed in the minimal images? |
dustymabe
reviewed
Dec 4, 2024
| @@ -1,6 +1,6 @@ | |||
| FROM registry.fedoraproject.org/fedora-minimal:41 | |||
There was a problem hiding this comment.
would switching to the non-minimal image here be a better move? i.e. would less rpms get downloaded in the dnf install below?
There was a problem hiding this comment.
it's not enough to fix this issue though, systemd is not in the non-minimal image either. So I'd rather stick with the smaller image
yeah sorry. But it was also removed from the non-minimal image so I just kept the minimal image and added systemd back |
dustymabe
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the F41 fedora-minimal image, systemctl stopped working. We need to enable tang.service in the container so we need systemd in the container.
Adding systemd in the container.