Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json rte serializer very large bundle size from dependencies #37

Merged
merged 5 commits into from
Jan 8, 2024
Merged

json rte serializer very large bundle size from dependencies #37

merged 5 commits into from
Jan 8, 2024

Conversation

Jayesh2812
Copy link
Contributor

@Jayesh2812 Jayesh2812 commented Jan 8, 2024 •
edited
Loading

For issue: #19

  1. Extracted jsx function from slate and slate-hyperscript
  2. Installing particular lodash helpers
  3. Added esbuild instead of tsc as bundler
  4. Minified the build.
  5. Final Build size , without the dependencies,( cjs and esm build included)

@Jayesh2812 Jayesh2812 requested a review from a team as a code owner January 8, 2024 05:27
RavenColEvol
RavenColEvol approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@RavenColEvol RavenColEvol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jayesh2812 Jayesh2812 merged commit db7b932 into development Jan 8, 2024
5 checks passed
@Jayesh2812 Jayesh2812 mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RavenColEvol RavenColEvol RavenColEvol approved these changes

@Ashwini-Rathod Ashwini-Rathod Awaiting requested review from Ashwini-Rathod

@hiteshshetty-dev hiteshshetty-dev Awaiting requested review from hiteshshetty-dev

@sairajchouhan sairajchouhan Awaiting requested review from sairajchouhan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jayesh2812 @RavenColEvol