Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing target attribute when parsing anchor tags and reducing bundle size #36

Merged
merged 15 commits into from
Jan 10, 2024
Merged

add missing target attribute when parsing anchor tags and reducing bundle size #36

merged 15 commits into from
Jan 10, 2024

Conversation

sairajchouhan
Copy link
Contributor

@sairajchouhan sairajchouhan commented Jan 4, 2024 •
edited by Jayesh2812
Loading

Resolving #19 with #37

@sairajchouhan sairajchouhan requested a review from a team as a code owner January 4, 2024 05:28
@Jayesh2812 Jayesh2812 changed the title add missing target attribute when parsing anchor tags add missing target attribute when parsing anchor tags and reducing bundle size Jan 8, 2024
@Jayesh2812 Jayesh2812 requested a review from a team January 8, 2024 12:41
Jayesh2812
Jayesh2812 previously approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@Jayesh2812 Jayesh2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hiteshshetty-dev
hiteshshetty-dev approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@hiteshshetty-dev hiteshshetty-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Ashwini-Rathod
Ashwini-Rathod approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@Ashwini-Rathod Ashwini-Rathod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me...!

@Jayesh2812 Jayesh2812 merged commit 27cf70b into master Jan 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashwini-Rathod Ashwini-Rathod Ashwini-Rathod approved these changes

@Jayesh2812 Jayesh2812 Jayesh2812 approved these changes

@hiteshshetty-dev hiteshshetty-dev hiteshshetty-dev approved these changes

@aravindbuilt aravindbuilt aravindbuilt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sairajchouhan @aravindbuilt @hiteshshetty-dev @Jayesh2812 @Ashwini-Rathod @Ashwini1997727