-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes 4952: add snaps list with temp list/fetch #874
Open
jlsherrill
wants to merge
3
commits into
content-services:main
Choose a base branch
from
jlsherrill:4952
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+112
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note this includes some changes from #865 so that will have to go in first and this be rebased. |
Hi @jlsherrill , please rebase. |
[test] |
/retest |
2 similar comments
/retest |
/retest |
[test] |
/retest |
|
/retest |
jlsherrill
force-pushed
the
4952
branch
2 times, most recently
from
November 25, 2024 20:12
ea78dfa
to
8409a7c
Compare
xbhouse
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good! just needs a rebase once this is merged and an api spec update in iqe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds snapshot list to template list and fetch api calls.
Testing steps
One thing to note is that the snapshot list isn't populated at creation time, but instead via the update_content_template task. I'm not sure we can do much at this time about it.