Fixed 4747: automatic deletion of outdated snapshots #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlsherrill
reviewed
Nov 25, 2024
| @@ -243,6 +244,7 @@ func setDefaults(v *viper.Viper) { | |||
| v.SetDefault("options.template_event_topic", "platform.content-sources.template") | |||
| v.SetDefault("options.repository_import_filter", "") | |||
| v.SetDefault("options.external_url", "http://pulp.content:8000") | |||
| v.SetDefault("options.snapshot_retain_days_limit", 90) | |||
There was a problem hiding this comment.
i'd probably set the default to a higher value (365), and then we can customize it in app-interface to do less for stage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds automatic deletion of outdated snapshots to the
nightly-jobscommand. The date after which the snapshots should be deleted is settable in the config.Also adds a list of snapshots which are going to be deleted in the next 14 days to the fetch/list template endpoints. (NOT DONE YET, DUE TO DEPENDING ON OTHER PRs)
Testing steps
#TODO