Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentencepiece 0.2.0 #48

Merged
merged 11 commits into from
Mar 15, 2024
Merged

sentencepiece 0.2.0 #48

merged 11 commits into from
Mar 15, 2024

Conversation

h-vetinari
Copy link
Member

A bunch of things have changed upstream, so we should be able to use abseil properly now (even though it symlinks to the third_party folder...). Also address #47 and use libprotobuf-lite (I didn't know -lite at the time and had thought it was another sentencepiece-ism).

* drop abseil workarounds to use new upstream option SPM_ABSL_PROVIDER
* drop patches messing with CMAKE_INSTALL_*
* link libprotobuf-lite instead of libprotobuf as intended by upstream
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

This is running into google/sentencepiece#978 on unix and needs conda-forge/libprotobuf-feedstock#210 on windows.

While modern protobuf already sets PROTOBUF_USE_DLLS in the
library interface, this does not seem to work as intended yet
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  •         'Test On Native Only' is deprecated.
    

This was used for disabling testing for cross-compiling.

This has been deprecated in favor of the top-level `test` field.
It is now mapped to `test: native_and_emulated`.
        Failed validating 'deprecated' in schema['properties']['test_on_native_only']:
            {'anyOf': [{'type': 'boolean'}, {'type': 'null'}],
             'default': False,
             'deprecated': True,
             'description': 'This was used for disabling testing for '
                            'cross-compiling.\n'
                            '\n'
                            '```warning\n'
                            'This has been deprecated in favor of the top-level '
                            '`test` field.\n'
                            'It is now mapped to `test: native_and_emulated`.\n'
                            '```',
             'title': 'Test On Native Only'}

        On instance['test_on_native_only']:
            True

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Mar 15, 2024
@github-actions github-actions bot merged commit 94d9131 into conda-forge:main Mar 15, 2024
8 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant