-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sentencepiece 0.2.0 #48
Conversation
* drop abseil workarounds to use new upstream option SPM_ABSL_PROVIDER * drop patches messing with CMAKE_INSTALL_* * link libprotobuf-lite instead of libprotobuf as intended by upstream
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This is running into google/sentencepiece#978 on unix and needs conda-forge/libprotobuf-feedstock#210 on windows. |
While modern protobuf already sets PROTOBUF_USE_DLLS in the library interface, this does not seem to work as intended yet
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
This was used for disabling testing for cross-compiling.
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
A bunch of things have changed upstream, so we should be able to use abseil properly now (even though it symlinks to the third_party folder...). Also address #47 and use libprotobuf-lite (I didn't know
-lite
at the time and had thought it was another sentencepiece-ism).