Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing CMAKE_INSTALL_LIBDIR to a relative path #47

Closed
jakirkham opened this issue Feb 15, 2024 · 2 comments
Closed

Changing CMAKE_INSTALL_LIBDIR to a relative path #47

jakirkham opened this issue Feb 15, 2024 · 2 comments

Comments

@jakirkham
Copy link
Member

According to the CMake docs, it is recommended that other CMAKE_INSTALL_* values are made relative to CMAKE_INSTALL_PREFIX

So would recommend changing CMAKE_INSTALL_LIBDIR here to be relative (IOW dropping $PREFIX)

sentencepiece-feedstock/recipe/build-lib.sh

Line 19 in 7bfee3f

-DCMAKE_INSTALL_LIBDIR=$PREFIX/lib \

@h-vetinari
Copy link
Member

PRs welcome!

@h-vetinari h-vetinari mentioned this issue Feb 20, 2024
Merged
@h-vetinari
Copy link
Member

This happened as of #48, together with some upstream fixes: google/sentencepiece@1d91514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakirkham @h-vetinari