Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully rewrite the golden tests runner using Alcotest #169

Merged
merged 20 commits into from
May 12, 2023
Merged

Fully rewrite the golden tests runner using Alcotest #169

merged 20 commits into from
May 12, 2023

Conversation

Niols
Copy link
Member

@Niols Niols commented May 10, 2023

No description provided.

@Niols Niols self-assigned this May 10, 2023
Base automatically changed from rename-golden-tests to main May 10, 2023 01:15
@Niols Niols force-pushed the rewrite-tests-runner branch from 5e33d64 to 8724653 Compare May 10, 2023 01:15
@Niols
Copy link
Member Author

Niols commented May 10, 2023

We use Alcotest.skip crucially, for which v1.7.0 at least is necessary. This will however make tests uninstallable on version of OCaml older than 4.10. I believe we should just drop support for those versions. Our reference is usually Debian stable which, currently, ships with OCaml 4.11.

@Niols Niols mentioned this pull request May 10, 2023
Open
@Niols
Copy link
Member Author

Niols commented May 10, 2023

Actually, Alcotest 1.7 compiles fine from OCaml 4.08 onwards. What blocked use was List.concat_map, so I got rid of this and removed official support for OCaml < 4.08. Note that, at this point, Morbig still compiles with older versions, but I don't think it makes much sense to check for that or limit ourselves for such old versions.

@Niols Niols linked an issue May 10, 2023 that may be closed by this pull request
Introduce Alcotest (or similar)-based unit tests for all the helper functions #166
Open
@Niols Niols removed a link to an issue May 10, 2023
Introduce Alcotest (or similar)-based unit tests for all the helper functions #166
Open
@Niols
Copy link
Member Author

Niols commented May 11, 2023

Waiting for #170. After that, I will be able to rebase and to use the newly introduced no-doc and no-tests flags in CI.

@Niols Niols force-pushed the rewrite-tests-runner branch from cf71e78 to 58a0085 Compare May 11, 2023 11:08
@Niols Niols force-pushed the rewrite-tests-runner branch 2 times, most recently from 67e348b to 6b2e7ee Compare May 11, 2023 15:46
@Niols Niols force-pushed the rewrite-tests-runner branch from 1b23ed6 to 0edf0b4 Compare May 12, 2023 12:29
@Niols Niols force-pushed the rewrite-tests-runner branch from 6e85488 to f8cf93c Compare May 12, 2023 15:00
@Niols Niols merged commit d678f96 into main May 12, 2023
@Niols Niols deleted the rewrite-tests-runner branch May 12, 2023 15:00
@Niols Niols mentioned this pull request May 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Niols Niols

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Niols