Strip tilde prefixes from WordTildePrefix
#164
Conversation
|
While investigating this, I actually found a few more bugs, namely:
88d6a2c introduces the two additional tests for |
|
The last commit adds two more test cases for words with tildes that are not assignment words. This is to check that Morbig is not overzealous in those cases and that it indeed does not find tilde prefixes in the middle of a colon-separated word. |
|
Alright, I think this is starting to look pretty good. However, I am quite puzzled by the way Morbig recognizes assignment words. In particular, Morbig recognizes assignment words on the right-hand side of a command name and I don't think this is right, but I have to read the standard some more before deciding what to think. That is not what |
|
Had to merge |
|
LGTM. I only add minor comments. |
Necessary for the `QCheck2`. We are not really using those features so much but it is a test dependency and 0.18 is a year and a half old.
|
The CI problem comes from the Archlinux image not managing to fetch |
|
LGTM! |
| ~name:"List.(bd @ [tl] = id)" | ||
| (list int) | ||
| (fun l -> | ||
| assume (List.compare_length_with l 2 >= 0); |
There was a problem hiding this comment.
Size 1 here would be sufficient, actually.
fix #163
In the example (taken from the tests)
X=~kn:~/bin:~darkvador/secretas an assignment word, Morbig parses the tilde prefixes asWordTildePrefix "~kn",WordTildePrefix "~"andWordTildePrefix "~darkvador". Since~is already contained as an information inWordTildePrefix, then it should be stripped off the carried string. This PR implements that.