Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2] Convert webhook handlers to Typescript #365

Merged
merged 12 commits into from
Oct 18, 2023
Merged

[2] Convert webhook handlers to Typescript #365

merged 12 commits into from
Oct 18, 2023

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Oct 9, 2023

This will make future modification to context & payloads easier.

@MrOrz MrOrz self-assigned this Oct 9, 2023
@MrOrz MrOrz marked this pull request as draft October 9, 2023 10:40
@coveralls
Copy link

coveralls commented Oct 9, 2023

Pull Request Test Coverage Report for Build 6535987939

  • 38 of 39 (97.44%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 90.012%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/webhook/handlers/askingArticleSubmissionConsent.ts 9 10 90.0%
Totals Coverage Status
Change from base Build 6535983227: -0.4%
Covered Lines: 1000
Relevant Lines: 1075

💛 - Coveralls

Copy link
Member Author

MrOrz commented Oct 9, 2023

@MrOrz MrOrz changed the title Convert webhook handlers to Typescript [2] Convert webhook handlers to Typescript Oct 9, 2023
@MrOrz MrOrz requested review from yhsiang, nonumpa and bil4444 and removed request for yhsiang October 9, 2023 16:01
@MrOrz MrOrz marked this pull request as ready for review October 9, 2023 16:02
@MrOrz MrOrz temporarily deployed to staging October 11, 2023 06:02 — with GitHub Actions Inactive
@MrOrz MrOrz temporarily deployed to staging October 12, 2023 12:14 — with GitHub Actions Inactive
Copy link
Member Author

MrOrz commented Oct 18, 2023

Merge activity

  • Oct 18, 2:04 PM: @MrOrz started a stack merge that includes this pull request via Graphite.
  • Oct 18, 2:04 PM: @MrOrz merged this pull request with Graphite.

Base automatically changed from ts-cleanup to master October 18, 2023 18:04
@MrOrz MrOrz merged commit 4153641 into master Oct 18, 2023
7 checks passed
@MrOrz MrOrz deleted the ts branch October 18, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants