fix(handlers): fix createTextMessage altText and update snapshot

- don't let altText leak to FlexComponent
cofacts · Oct 16, 2023 · 2e04335 · 2e04335
1 parent c84199b
commit 2e04335
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 9 deletions.
diff --git a/src/webhook/handlers/__tests__/askingArticleSource.test.js b/src/webhook/handlers/__tests__/askingArticleSource.test.js
@@ -35,7 +35,7 @@ it('returns instructions if user did not forward the whole message', async () =>
   expect(replies).toMatchInlineSnapshot(`
     Array [
       Object {
-        "altText": "",
+        "altText": "Instructions",
         "contents": Object {
           "body": Object {
             "contents": Array [

diff --git a/src/webhook/handlers/utils.ts b/src/webhook/handlers/utils.ts
@@ -7,6 +7,7 @@ import type {
   TextMessage,
   FlexMessage,
   FlexText,
+  FlexComponent,
 } from '@line/bot-sdk';
 import { t, msgid, ngettext } from 'ttag';
 import GraphemeSplitter from 'grapheme-splitter';
@@ -715,21 +716,34 @@ type FlexTextWithoutType =
  * @returns A single flex bubble message
  */
 export function createTextMessage(textProps: FlexTextWithoutType): FlexMessage {
+  const altText = 'altText' in textProps ? textProps.altText : textProps.text;
+
+  const content: FlexComponent = {
+    type: 'text',
+    wrap: true,
+    // Exclude altText from FlexComponent content
+    ...(() => {
+      if (!('altText' in textProps)) {
+        return textProps;
+      }
+      const {
+        // eslint-disable-next-line @typescript-eslint/no-unused-vars
+        altText,
+        ...other
+      } = textProps;
+      return other;
+    })(),
+  };
+
   return {
     type: 'flex',
-    altText: textProps.text ?? textProps.altText,
+    altText,
     contents: {
       type: 'bubble',
       body: {
         type: 'box',
         layout: 'vertical',
-        contents: [
-          {
-            type: 'text',
-            wrap: true,
-            ...textProps,
-          },
-        ],
+        contents: [content],
       },
     },
   };