fix(webhook): craeteTextMessage() with contents must provide altText

Fix issue found in https://g0v.hackmd.io/t9ypB87SQBuMjjW_PheZVg#%E2%9B%94%EF%B8%8F-Release-Blockers
cofacts · Oct 16, 2023 · c84199b · c84199b
1 parent a0e933c
commit c84199b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/webhook/handlers/askingArticleSource.ts b/src/webhook/handlers/askingArticleSource.ts
@@ -27,6 +27,7 @@ const askingArticleSource: ChatbotStateHandler = async (params) => {
     case POSTBACK_NO:
       replies = [
         createTextMessage({
+          altText: t`Instructions`,
           contents: [
             {
               type: 'span',

diff --git a/src/webhook/handlers/utils.ts b/src/webhook/handlers/utils.ts
@@ -691,10 +691,17 @@ export function createCommentBubble(articleId: string): FlexBubble {
 }
 
 /**
- * Omit<> breaks FlexText's union, thus we Omit<> separately and then union back
+ * Omit<> breaks FlexText's discriminated union, thus we Omit<> separately and then union back
  */
 type FlexTextWithoutType =
-  | Omit<FlexText & { text?: never; contents: FlexSpan[] }, 'type'>
+  | Omit<
+      FlexText & {
+        /* Discriminator */ text?: never;
+        contents: FlexSpan[];
+        /* Must be supplied in this case */ altText: string;
+      },
+      'type'
+    >
   | Omit<FlexText & { text: string; contents?: never }, 'type'>;
 
 /**
@@ -710,7 +717,7 @@ type FlexTextWithoutType =
 export function createTextMessage(textProps: FlexTextWithoutType): FlexMessage {
   return {
     type: 'flex',
-    altText: textProps.text ?? '',
+    altText: textProps.text ?? textProps.altText,
     contents: {
       type: 'bubble',
       body: {