-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On-boarding tutorial #231
On-boarding tutorial #231
Conversation
Pull Request Test Coverage Report for Build 1199
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not finish reviewing handlers/tutorial.js
. Here are some early feedback.
da1203f
to
aaca9e0
Compare
e78fd9b
to
fec5de9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The unit tests are extremely helpful when I read through the code. Thanks for providing the thorough tests cases!
I have some comments regarding wording and how replies
array can be constructed.
fec5de9
to
6132c7f
Compare
…tions from choosingReply
- tutorial sends postback message - rich menu sends text message
… permission setup ui" This reverts commit 2633552.
…ript and simplify replies‘ assignment
6132c7f
to
b1989a9
Compare
In order to achieve that, I need to ask for your permission to \\"send your message to our chatroom\\". | ||
The permission will be used to send only this one message of yours back to this parti⋯⋯ | ||
In order to achieve that, I need to ask for your permission to \\"Send messages to chats\\". | ||
The permission will be used to send only this one message of yours back to this particular chatr⋯⋯ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text will ellipsis before assigning to altText, so the snapshot looks a little weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's merge!
Fixes #216
Text setup in rich menu to trigger tutorial should be:
📖 tutorial (en)
📖 教學 (zh-tw)
Snapshot