Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty ephemeral tags in post drafts if the draft is saved with no tags #1458

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Fix empty ephemeral tags in post drafts if the draft is saved with no tags #1458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8255f28
when saving post drafts, do not insert nil records in Redis (tags list)
Oaphi Dec 1, 2024
70f7d1c
added a script for cleaning up post drafts
Oaphi Dec 1, 2024
d0f9d5d
added cleanup_drafts as a daily job
Oaphi Dec 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/controllers/posts_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,7 +602,9 @@ def save_draft
key_name = [:body, :saved_at].include?(key) ? base_key : "#{base_key}.#{key}"

if key == :tags
RequestContext.redis.sadd(key_name, params[key])
if params[key].present?
RequestContext.redis.sadd(key_name, params[key])
end
else
RequestContext.redis.set(key_name, params[key])
end
Expand Down
4 changes: 4 additions & 0 deletions config/schedule.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
runner 'scripts/run_spam_cleanup.rb'
end

every 1.day, at: '02:20' do
runner 'scripts/cleanup_drafts.rb'
end

every 6.hours do
runner 'scripts/recalc_abilities.rb'
end
5 changes: 5 additions & 0 deletions scripts/cleanup_drafts.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
redis = RequestContext.redis

redis.scan_each(:match => "saved_post.*.*.tags") do |key|
redis.srem?(key, '')
end
Loading