Fix empty ephemeral tags in post drafts if the draft is saved with no tags #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested and do not see the bug on this branch, but I do on |
ArtOfCode-
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1457
This PR fixes an issue with saving post drafts with no tags. Due to a
nullvalue coming from a completely empty tag field, we end up persisting anilvalue in Redis. This results in conversion to an empty string on load, which in turn ends up showing an empty tag box in the field.Also introduces a daily job for automatic cleanup of drafts (for now, the only action is to non-destructively fix existing drafts).