-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework of the character count requirements display #1189
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oaphi
added
area: ruby
Changes to server-side code
area: html/css/js
Changes to front-end code
complexity: easy
Issues that should take limited effort to resolve/fix/build.
labels
Aug 23, 2023
Oaphi
force-pushed
the
0valt/1145/show-min-length-char-reqs
branch
from
September 25, 2023 09:32
1a9edc8
to
47a4d21
Compare
ArtOfCode-
requested changes
Oct 3, 2023
…ButtonState) clearer
ArtOfCode-
approved these changes
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: html/css/js
Changes to front-end code
area: ruby
Changes to server-side code
complexity: easy
Issues that should take limited effort to resolve/fix/build.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the display of character count requirements, including:
setCounterState
,setInputState
,setSubmitButtonState
) for the character_count JS handler;The following is an example of how the character count will work after the change:
Screencast.from.23.08.2023.17.19.13.webm
Closes #1145