Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counter on editing tag summaries is always 0 #1261

Closed
cellio opened this issue Nov 30, 2023 · 3 comments · Fixed by #1267
Closed

Counter on editing tag summaries is always 0 #1261

cellio opened this issue Nov 30, 2023 · 3 comments · Fixed by #1267
Assignees
Labels
area: html/css/js Changes to front-end code complexity: easy Issues that should take limited effort to resolve/fix/build. priority: medium type: bug Something isn't working

Comments

@cellio
Copy link
Member

cellio commented Nov 30, 2023

Most editing textboxes (posts, comments, etc) now show a counter so you know when you've reached a minimum length or exceeded a max. However, the counter on tag summaries (the short description) doesn't work; it stays at 0/600 while I type. The long tag description, on the other hand, correctly shows progress toward the 30,000-character max:

screenshot

I wonder if this has something to do with the backing element type -- I notice that the summary and description also use different font faces, so the UI apparently "thinks" they're different kinds of things. I don't know if that's relevant.

Possibly related for a fix: #1189 . The bug predates that change.

@cellio cellio added area: html/css/js Changes to front-end code type: bug Something isn't working priority: medium complexity: unassessed Needs further developer investigation before complexity/feasibility can be determined. labels Nov 30, 2023
@Oaphi Oaphi self-assigned this Nov 30, 2023
@Oaphi
Copy link
Member

Oaphi commented Nov 30, 2023

huh, I thought I found all use cases for the counters. Assigning to myself as I've recently tackled #1189

@cellio
Copy link
Member Author

cellio commented Nov 30, 2023

Thanks. Just to be clear, it was already broken when you got there. You didn't do it. But having worked on that, you might know how to fix it. :-)

@Oaphi Oaphi added complexity: easy Issues that should take limited effort to resolve/fix/build. and removed complexity: unassessed Needs further developer investigation before complexity/feasibility can be determined. labels Dec 1, 2023
@Oaphi
Copy link
Member

Oaphi commented Dec 1, 2023

@cellio yup, I do know how to address that — already done (and threw in a couple more improvements along the way), awaiting review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: html/css/js Changes to front-end code complexity: easy Issues that should take limited effort to resolve/fix/build. priority: medium type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants