Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHEL/Fedora now defaults to setting crashkernel #19473

Merged
merged 3 commits into from
Oct 13, 2023
Merged

RHEL/Fedora now defaults to setting crashkernel #19473

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccb0adc
kdump: RHEL/Fedora now defaults to setting crashkernel
jelly Oct 12, 2023
d38eb24
test: fedora-testing image is no more
jelly Oct 12, 2023
ba16f96
test: cleanup NFS test case
jelly Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 26 additions & 18 deletions test/verify/check-kdump
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,19 @@ from lib.constants import TEST_OS_DEFAULT


class KdumpHelpers(testlib.MachineCase):
def setUp(self):
super().setUp()
self.allow_restart_journal_messages()

def enableKdump(self):
martinpitt marked this conversation as resolved.
Show resolved Hide resolved
# all current Fedora/CentOS/RHEL images use BootLoaderSpec
self.machine.execute("grubby --args=crashkernel=256M --update-kernel=ALL")
self.machine.execute("mkdir -p /var/crash")
self.machine.reboot()
self.allow_restart_journal_messages()
self.machine.start_cockpit()
self.browser.switch_to_top()
self.browser.relogin("/kdump")
if self.machine.image == "fedora-38":
self.machine.execute("grubby --args=crashkernel=192M --update-kernel=ALL")
self.machine.reboot()

self.machine.start_cockpit()
self.browser.switch_to_top()
self.browser.relogin("/kdump")

def crashKernel(self, message, cancel=False):
b = self.browser
Expand Down Expand Up @@ -68,7 +72,10 @@ class TestKdump(KdumpHelpers):
m = self.machine

b.wait_timeout(120)
m.execute("systemctl enable kdump; systemctl start kdump || true")
if m.image.startswith("fedora"):
martinpitt marked this conversation as resolved.
Show resolved Hide resolved
m.execute("systemctl enable --now kdump")
else:
m.execute("until systemctl is-active kdump; do sleep 1; done")

self.login_and_go("/kdump")

Expand All @@ -77,7 +84,7 @@ class TestKdump(KdumpHelpers):
def assertActive(active):
b.wait_visible(".pf-v5-c-switch__input" + (active and ":checked" or ":not(:checked)"))

if m.image in ["fedora-38", "fedora-testing"]:
if m.image in ["fedora-38"]:
# crashkernel command line not set
b.wait_visible(".pf-v5-c-switch__input:disabled")
# right now we have no memory reserved
Expand Down Expand Up @@ -147,8 +154,8 @@ class TestKdump(KdumpHelpers):
b.wait_not_present(pathInput)
self.crashKernel("copied through SSH to root@localhost:/var/crash as vmcore", cancel=True)

# we should have the amount of memory reserved that we indicated
b.wait_in_text("#app", "256 MiB")
# we should have the amount of memory reserved that crashkernel=auto defaults to for our VM RAM size
b.wait_in_text("#app", "192 MiB")
# service should start up properly and the button should be on
b.wait_in_text("#app", "Service is running")
assertActive(active=True)
Expand Down Expand Up @@ -416,10 +423,10 @@ class TestKdumpNFS(KdumpHelpers):
self.machines["nfs"].write("/etc/exports", "/srv/kdump 10.111.113.0/24(rw,no_root_squash)\n")
self.machines["nfs"].execute("mkdir -p /srv/kdump/var/crash; firewall-cmd --add-service nfs; systemctl restart nfs-server")

# there shouldn't be any crash reports in the target directory
martinpitt marked this conversation as resolved.
Show resolved Hide resolved
self.assertEqual(m.execute("find /var/crash -maxdepth 1 -mindepth 1 -type d"), "")

# set up client machine
m.execute("systemctl disable kdump")
# ensure there is no local /var/crash, should not break kdump
m.execute("rmdir /var/crash")
self.login_and_go("/kdump")
self.enableKdump()

Expand All @@ -435,10 +442,11 @@ class TestKdumpNFS(KdumpHelpers):
b.wait_not_present("#kdump-settings-dialog")

# enable service, regenerates initrd and tests NFS settings
b.wait_visible(".pf-v5-c-switch__input:not(:checked)")
b.click(".pf-v5-c-switch__input")
with b.wait_timeout(300):
b.wait_visible(".pf-v5-c-switch__input:checked")
if m.image.startswith("fedora"):
b.wait_visible(".pf-v5-c-switch__input:not(:checked)")
b.click(".pf-v5-c-switch__input")
with b.wait_timeout(300):
b.wait_visible(".pf-v5-c-switch__input:checked")
b.wait_in_text("#app", "Service is running")

# explicit nfs option, unset path
Expand Down