RHEL/Fedora now defaults to setting crashkernel #19473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelly
added
the
no-test
jelly
force-pushed
the
kdump-crashkernel-default
branch
from
5ed8755 to
30a0aeb
Compare
jelly
changed the title
jelly
removed
the
no-test
martinpitt
requested changes
Oct 13, 2023
jelly
force-pushed
the
kdump-crashkernel-default
branch
from
41d84ea to
657302e
Compare
martinpitt
requested changes
Oct 13, 2023
jelly
force-pushed
the
kdump-crashkernel-default
branch
from
657302e to
74eecad
Compare
martinpitt
previously approved these changes
Oct 13, 2023
In Fedora-39 and all supported RHEL versions (8 and 9) crashkernel is now set in the default cmdline. RHEL also defaults in enabling kdump.service which Fedora does not. This simplifies our testing as we don't have to re-generate initrd and reboot. Plus this means we test the distribution default which is a lot more useful then an arbitrary setting we came up with.
This was replaced with a custom `TEST_SCENARIO`.
Drop the removal of /var/crash, enableKdump used to re-create it anyway. Test if the dir is empty like TestKdump.testBasic does.
jelly
force-pushed
the
kdump-crashkernel-default
branch
from
74eecad to
ba16f96
Compare
|
Not sure what to make of this failure, but it could be a "normal" timeout flake, so worth retrying. |
The kdump tests are very sensitive to test infra being under load. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not save us a lot of time, as even on RHEL we need to re-generate the initrd however we do skip one reboot which can be flaky.
But what is a nice side effect is that we now test the Distro default crashkernel setting.