Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various PF fixes #19074

Merged
merged 4 commits into from
Jul 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/lib/cockpit-components-modifications.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,10 @@ class ModificationsExportDialog extends React.Component {
title={_("Automation script") }>
<Tabs activeKey={this.state.active_tab} onSelect={this.handleSelect}>
<Tab eventKey="shell" title={_("Shell script")}>
<TextArea resizeOrientation='vertical' isReadOnly defaultValue={this.props.shell.trim()} />
<TextArea resizeOrientation='vertical' readOnlyVariant="default" defaultValue={this.props.shell.trim()} />
</Tab>
<Tab eventKey="ansible" title={_("Ansible")}>
<TextArea resizeOrientation='vertical' isReadOnly defaultValue={this.props.ansible.trim()} />
<TextArea resizeOrientation='vertical' readOnlyVariant="default" defaultValue={this.props.ansible.trim()} />
<div className="ansible-docs-link">
<OutlinedQuestionCircleIcon />
{ _("Create new task file with this content.") }
Expand Down
2 changes: 1 addition & 1 deletion pkg/lib/cockpit-components-table.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ export const ListingTable = ({
const rowsComponents = (isSortable ? (sortMethod ? sortMethod(rows, activeSortDirection, activeSortIndex) : sortRows()) : rows).map((row, rowIndex) => {
const rowProps = row.props || {};
if (onRowClick) {
rowProps.isHoverable = true;
rowProps.isClickable = true;
rowProps.onRowClick = (event) => onRowClick(event, row);
}

Expand Down
4 changes: 2 additions & 2 deletions pkg/selinux/setroubleshoot-view.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class SELinuxEventDetails extends React.Component {

// One line usually means one command
if (itm.doText && itm.doText.indexOf("\n") < 0)
doElement = <TextArea aria-label={_("solution")} isReadOnly defaultValue={itm.doText} />;
doElement = <TextArea aria-label={_("solution")} readOnlyVariant="default" defaultValue={itm.doText} />;

// There can be text with commands. Command always starts on a new line with '#'
// Group subsequent commands into one `<TextArea>` element.
Expand All @@ -142,7 +142,7 @@ class SELinuxEventDetails extends React.Component {
});
doElement = parts.map((p, index) => p[0] == "#"
? <TextArea aria-label={_("solution")}
isReadOnly
readOnlyVariant="plain"
key={p}
defaultValue={p.substr(2)} />
: <span key={p}>{p}</span>);
Expand Down
2 changes: 1 addition & 1 deletion pkg/shell/superuser.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ const UnlockDialog = ({ proxy, host }) => {
<Form isHorizontal>
<FormGroup fieldId="switch-to-admin-access-bridge-select"
label={_("Method")}>
<FormSelect value={method} onChange={(_, method) => setMethod(method)} isDisabled={busy}>
<FormSelect id="switch-to-admin-access-bridge-select" value={method} onChange={(_, method) => setMethod(method)} isDisabled={busy}>
{ methods.map(m => <FormSelectOption value={m} key={m}
label={_(proxy.Methods[m].v.label.v)} />) }
</FormSelect>
Expand Down
2 changes: 1 addition & 1 deletion pkg/systemd/abrtLog.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import { journal } from "journal";

const _ = cockpit.gettext;

const Table = ({ lines, delimiter, type }) => {
const Table = ({ lines, delimiter }) => {
return (
<DescriptionList className="pf-m-horizontal-on-sm">
{ lines.map((line, idx) => {
Expand Down