Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various PF fixes #19074

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Various PF fixes #19074

merged 4 commits into from
Jul 7, 2023

Conversation

jelly
Copy link
Member

@jelly jelly commented Jul 5, 2023

Deprecations / missing title found by making extranous console.error fail. Split up from #19053

@jelly
shell: add missing id for FormSelect
6b2ceaf 
The FormGroup has a fieldId but we never set the id on the FormSelect.
@jelly jelly requested a review from martinpitt July 5, 2023 14:23
martinpitt
martinpitt reviewed Jul 5, 2023
View reviewed changes
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good by and large, but I'd like to at least discuss the hardcoded "Fedora" string. Maybe it's okay :-)

pkg/systemd/reporting.jsx Outdated
@@ -226,6 +226,7 @@ class BusWorkflowRow extends React.Component {
this.setState({ message: _("Waiting for input…") });
const task_prompt = client.proxy("org.freedesktop.reportd.Task.Prompt", object_path);
const props = {
title: _("Report to Fedora?"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this justified? Shouldn't "Fedora" come from some metadata of the backend?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good point! I think the text comes from reportd/taskd so this is 💯 wrong.

@jelly
Copy link
Member Author

jelly commented Jul 6, 2023

This looks good by and large, but I'd like to at least discuss the hardcoded "Fedora" string. Maybe it's okay :-)

image

So this is where my confusion started :)

@jelly
Copy link
Member Author

jelly commented Jul 6, 2023

This looks good by and large, but I'd like to at least discuss the hardcoded "Fedora" string. Maybe it's okay :-)

image

So this is where my confusion started :)

Report to Fedora comes from some label.

This looks good by and large, but I'd like to at least discuss the hardcoded "Fedora" string. Maybe it's okay :-)

image

So this is where my confusion started :)

More meh, we should maybe just fix the UX here. You can't report without an API key. So maybe Report should be disabled and we should show a setup button first? @garrett (We have an open issue for reportd)

#19059

So I'll drop this commit here, let's focus on making something better and adding a Title.

image

@jelly jelly requested a review from KKoukiou July 7, 2023 16:15
@jelly jelly merged commit 0d85fbd into cockpit-project:main Jul 7, 2023
@jelly jelly deleted the various-fixes branch July 7, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpitt martinpitt martinpitt left review comments

@KKoukiou KKoukiou KKoukiou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jelly @martinpitt @KKoukiou