[DD4hep] Convert Reflections via TGeo Reflection Factory

[ianna]

PR description:

• While waiting for a proper solution from DD4hep: temporarily use a TGeo reflection factory to convert reflections before calling the DD4hep G4 converter

@bsunanda - FYI

• As we have discussed, the CSC sim hits in -Z look good now
• All EE sim hits are present

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31970/19430

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/DDCMS

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-10-27-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10345/console Started: 2020/10/28 15:10

[cmsbuild]

-1

Tested at: 0f871e5

CMSSW: CMSSW_11_2_X_2020-10-27-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abc633/10345/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test testDD4hepDDSolid had ERRORS

[cmsbuild]

Comparison job queued.

[cmsbuild]

The code-checks are being triggered in jenkins.

[ianna]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31970/19437

• This PR adds an extra 28KB to repository

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-10-27-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10361/console Started: 2020/10/28 17:01

[cmsbuild]

+1
Tested at: 82e5096
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abc633/10361/summary.html
CMSSW: CMSSW_11_2_X_2020-10-27-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abc633/10361/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2544092
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2544063
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

@ianna Would you mind to move from cout to edm::LogInfo or something like that (see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideMessageLogger ) ? std::cout is not thread safe, so we should move away from it (see cms-sw/cms-sw.github.io#94)

[ianna]

@qliphy - thanks for pointing it out. Since all unit tests use std::cout I'll do it in a separate PR.

[qliphy]

+1

[makortel]

Since all unit tests use std::cout

std::cout is fine in unit tests...

[ianna]

Since all unit tests use std::cout

std::cout is fine in unit tests...

no action needed then :-)

[mrodozov]

please test for CMSSW_11_2_X_2020-10-28-2300

[mrodozov]

abort
forgot to add the part that is failing. this PR broke unit test
MagneticFieldEngineTestDriver

[ianna]

abort
forgot to add the part that is failing. this PR broke unit test
MagneticFieldEngineTestDriver

sorry about that. I'll have a look shortly.

[mrodozov]

alright, it's in the last IB, I won't start the test here then (it's redundant to "prove" it)

[silviodonato]

Yes, I confirm that this PR is the origin of the issue #31987 ( test MagneticFieldEngineTestDriver had ERRORS )