Remove use of TGeo to convert reflections #32112
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32112/19763
|
|
A new Pull Request was created by @ghugo83 for master. It involves the following packages: DetectorDescription/DDCMS @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| @@ -2245,8 +2245,6 @@ static long load_dddefinition(Detector& det, xml_h element) { | |||
|
|
|||
| // Can not deal with reflections without closed geometry | |||
| det.manager().CloseGeometry(); | |||
| // Convert reflections via TGeo reflection factory | |||
There was a problem hiding this comment.
@ghugo83 - you can also delete the previous line. It’s not needed to close the geometry here.
Thanks!
|
+1 @smuzaffar and @silviodonato - FYI, since we do not use the TGeo reflection factory, the ROOT title bug is not relevant and the unit test is fixed with this PR. |
cmsbuild
added
fully-signed
geometry-approved
and removed
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Now that the reflections conversion is handled in DD4hep, remove use of TGeo reflection factory to convert reflections.
This PR (together with #32000) reverts #31970 .
@ianna @bsunanda