feat(eventgenerator): Integrate cf api with event generator #3357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonzofenix
changed the base branch from
main
to
add-cf-endpoint-to-eventgenerator
bonzofenix
force-pushed
the
integrate-cf-api-with-eventgenerator
branch
6 times, most recently
from
87801c3 to
2cdfad3
Compare
bonzofenix
force-pushed
the
add-cf-endpoint-to-eventgenerator
branch
from
0607dfe to
05c7cc4
Compare
bonzofenix
force-pushed
the
integrate-cf-api-with-eventgenerator
branch
from
2cdfad3 to
0108dda
Compare
bonzofenix
force-pushed
the
integrate-cf-api-with-eventgenerator
branch
from
0108dda to
12a4687
Compare
bonzofenix
force-pushed
the
add-cf-endpoint-to-eventgenerator
branch
2 times, most recently
from
40028b5 to
00083e4
Compare
bonzofenix
force-pushed
the
integrate-cf-api-with-eventgenerator
branch
3 times, most recently
from
0100ccb to
53fbafc
Compare
bonzofenix
changed the title
Co-authored-by: Silvestre Zabala <[email protected]>
Co-authored-by: Silvestre Zabala <[email protected]>
silvestre
requested changes
Dec 5, 2024
…ScalingPolicy function.
- handle CF_INSTANCE_CERT and CF_INSTANCE_KEY - Remove `CfInstanceCert` from `Config` struct and related code - Generate RSA keys and certificates for testing in `api_test.go` and `config_test.go` - Set environment variables for instance keys and certs in tests - Update `config#configureEventGenerator` to use environment variables for TLS config - Remove unused `auth` import and related code in `public_api_handler.go` - Create `MaterializeContentInFile` function in `configutil` for file operations - Add `GenerateClientCertWithPrivateKey` and `GenerateClientKeyWithPrivateKey` in `testhelpers`
…n PublicApiHandler
• Eliminate GetCfInstanceCert method and associated environment variable usage. • Update tests to reflect removal of CF_INSTANCE_CERT handling.
- Make `generate-fakes` target `.PHONY` in Makefile - Remove dependency of `generate-fakes` from `testsuite` target - Simplify `configureEventGenerator` function by directly setting `CertFile` and `KeyFile` from environment variables - Update tests to reflect changes in `configureEventGenerator` and remove unnecessary file creation for `CF_INSTANCE_CERT` and `CF_INSTANCE_KEY`
bonzofenix
force-pushed
the
integrate-cf-api-with-eventgenerator
branch
4 times, most recently
from
4ec6bdc to
3f43eba
Compare
bonzofenix
force-pushed
the
integrate-cf-api-with-eventgenerator
branch
from
3f43eba to
bf9e05e
Compare
bonzofenix
force-pushed
the
integrate-cf-api-with-eventgenerator
branch
from
9331fbe to
f5b31e8
Compare
…iration • Changed certExpiration from a pointer to a non-pointer time.Time type. • Updated GetCertExpiration and certificateExpiringWithin methods to handle the non-pointer type. • Removed unnecessary pointer dereferences in httpclient_test.go.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event generator must allow requests from incoming API component running on CF. This PR introduces handling allowed space and org GUID through XFCC authentication.
Key Changes:
CfInstanceCertfield to theeventgenerator#Configmodel.XFCCAuthMiddleware:src/autoscaler/integration/integration_golangapi_eventgenerator_test.gosrc/autoscaler/api/publicapiserver/public_api_handler.go