-
Notifications
You must be signed in to change notification settings - Fork 52
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adds initial implementation of TLSReloadTransport
- Loading branch information
1 parent
67b868d
commit bf9e05e
Showing
5 changed files
with
195 additions
and
35 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,143 @@ | ||
| package helpers_test | ||
|
|
||
| import ( | ||
| "crypto/rand" | ||
| "crypto/rsa" | ||
| "crypto/tls" | ||
| "crypto/x509" | ||
| "encoding/pem" | ||
| "log" | ||
| "net/http" | ||
| "os" | ||
| "time" | ||
|
|
||
| "code.cloudfoundry.org/app-autoscaler/src/autoscaler/configutil" | ||
| "code.cloudfoundry.org/app-autoscaler/src/autoscaler/helpers" | ||
| "code.cloudfoundry.org/app-autoscaler/src/autoscaler/models" | ||
| "code.cloudfoundry.org/app-autoscaler/src/autoscaler/testhelpers" | ||
| "code.cloudfoundry.org/lager/v3/lagertest" | ||
| "github.com/hashicorp/go-retryablehttp" | ||
| . "github.com/onsi/ginkgo/v2" | ||
| . "github.com/onsi/gomega" | ||
| "github.com/onsi/gomega/gbytes" | ||
| "github.com/onsi/gomega/ghttp" | ||
| ) | ||
|
|
||
| var _ = Describe("HTTPClient", func() { | ||
| var ( | ||
| fakeServer *ghttp.Server | ||
| client *http.Client | ||
| logger *lagertest.TestLogger | ||
| err error | ||
| ) | ||
|
|
||
| BeforeEach(func() { | ||
| fakeServer = ghttp.NewServer() | ||
| fakeServer.RouteToHandler("GET", "/", ghttp.RespondWith(http.StatusOK, "successful")) | ||
| }) | ||
|
|
||
| Describe("CreateHTTPSClient", func() { | ||
| var ( | ||
| cfInstanceCertFile string | ||
| cfInstanceKeyFile string | ||
| cfInstanceCertContent []byte | ||
| cfInstanceKeyContent []byte | ||
| notAfter time.Time | ||
| certTmpDir string | ||
| privateKey *rsa.PrivateKey | ||
| ) | ||
|
|
||
| JustBeforeEach(func() { | ||
| privateKey, err = rsa.GenerateKey(rand.Reader, 2048) | ||
| Expect(err).ToNot(HaveOccurred()) | ||
|
|
||
| cfInstanceCertContent, err = testhelpers.GenerateClientCertWithPrivateKeyExpiring("org", "space", privateKey, notAfter) | ||
| certTmpDir = os.TempDir() | ||
| cfInstanceKeyContent = testhelpers.GenerateClientKeyWithPrivateKey(privateKey) | ||
|
|
||
| cfInstanceCertFile, err = configutil.MaterializeContentInFile(certTmpDir, "eventgenerator.crt", string(cfInstanceCertContent)) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| cfInstanceKeyFile, err = configutil.MaterializeContentInFile(certTmpDir, "eventgenerator.key", string(cfInstanceKeyContent)) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| logger = lagertest.NewTestLogger("http-client-test") | ||
|
|
||
| tlsCerts := &models.TLSCerts{ | ||
| KeyFile: cfInstanceKeyFile, | ||
| CertFile: cfInstanceCertFile, | ||
| CACertFile: cfInstanceCertFile, | ||
| } | ||
|
|
||
| client, err = helpers.CreateHTTPSClient(tlsCerts, helpers.DefaultClientConfig(), logger) | ||
| Expect(err).ToNot(HaveOccurred()) | ||
| }) | ||
|
|
||
| AfterEach(func() { | ||
| os.Remove(cfInstanceCertFile) | ||
| os.Remove(cfInstanceKeyFile) | ||
| }) | ||
|
|
||
| When("Cert cert is not within 1 hour of expiration", func() { | ||
| BeforeEach(func() { | ||
| notAfter = time.Now().Add(63 * time.Minute) | ||
| }) | ||
|
|
||
| It("should reload the cert", func() { | ||
| Expect(client).ToNot(BeNil()) | ||
| client.Get(fakeServer.URL()) | ||
| Expect(logger).To(gbytes.Say("cert-not-expiring")) | ||
| }) | ||
| }) | ||
|
|
||
| When("Cert cert is within 1 hour of expiration", func() { | ||
| var cfInstanceCertFileToRotateContent []byte | ||
|
|
||
| BeforeEach(func() { | ||
| notAfter = time.Now().Add(59 * time.Minute) | ||
| }) | ||
|
|
||
| It("should reload the cert", func() { | ||
| cfInstanceCertFileToRotateContent, err = testhelpers.GenerateClientCertWithPrivateKey("org", "space", privateKey) | ||
| Expect(err).ToNot(HaveOccurred()) | ||
|
|
||
| By("Rotating with unexpired one") | ||
| _, err = configutil.MaterializeContentInFile(certTmpDir, "eventgenerator.crt", string(cfInstanceCertFileToRotateContent)) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| Expect(getCertFromClient(client)).To(Equal(string(cfInstanceCertContent))) | ||
| client.Get(fakeServer.URL()) | ||
| Expect(logger).To(gbytes.Say("reloading-cert")) | ||
|
|
||
| Expect(getCertFromClient(client)).To(Equal(string(cfInstanceCertFileToRotateContent))) | ||
| }) | ||
| }) | ||
| }) | ||
| }) | ||
|
|
||
| func getCertFromClient(client *http.Client) string { | ||
| GinkgoHelper() | ||
| cert := client.Transport.(*helpers.TLSReloadTransport).Base.(*retryablehttp.RoundTripper).Client.HTTPClient.Transport.(*http.Transport).TLSClientConfig.Certificates[0] | ||
| return getPEM(cert) | ||
| } | ||
|
|
||
| func getPEM(cert tls.Certificate) string { | ||
| result := "" | ||
|
|
||
| for _, certBytes := range cert.Certificate { | ||
| parsedCert, err := x509.ParseCertificate(certBytes) | ||
| if err != nil { | ||
| log.Printf("Failed to parse certificate: %v", err) | ||
| continue | ||
| } | ||
|
|
||
| // Encode to PEM format | ||
| pemBlock := &pem.Block{ | ||
| Type: "CERTIFICATE", | ||
| Bytes: parsedCert.Raw, | ||
| } | ||
| result += string(pem.EncodeToMemory(pemBlock)) | ||
| } | ||
|
|
||
| return result | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters