Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): Add devbox config #2914

Merged
merged 3 commits into from
May 3, 2024
Merged

feat(deps): Add devbox config #2914

merged 3 commits into from
May 3, 2024

Conversation

silvestre
Copy link
Member

@silvestre silvestre commented Apr 30, 2024

Issue

Specifying exact versions for dependencies in Nix is not
straightforward.

Fix

This commit adds a basic devbox configuration for our project.

If you want to try it out: Install devbox and run devbox shell

This PR also adds a script that tries to keep the version in devbox.json in sync with those in .tool-versions, scripts/asdf2devbox.py. That script is also used by a GitHub Actions workflow, triggered whenever .tool-versions is changed.

scripts/asdf2devbox.sh Outdated Show resolved Hide resolved
.github/workflows/asdf2devbox.yaml Show resolved Hide resolved
.github/workflows/asdf2devbox.yaml Show resolved Hide resolved
.github/workflows/asdf2devbox.yaml Show resolved Hide resolved
.github/workflows/asdf2devbox.yaml Show resolved Hide resolved
.github/workflows/asdf2devbox.yaml Show resolved Hide resolved
.github/workflows/asdf2devbox.yaml Show resolved Hide resolved
.github/workflows/asdf2devbox.yaml Show resolved Hide resolved
.github/workflows/asdf2devbox.yaml Show resolved Hide resolved
@silvestre silvestre force-pushed the devbox branch 6 times, most recently from b735d64 to 4a92a0f Compare May 3, 2024 10:45
silvestre added 2 commits May 3, 2024 13:08
# Issue

Specifying exact versions for dependencies in Nix is not
straightforward.

# Fix

This commit adds a basic `devbox` configuration for our project.

If you want to try it out:  [Install devbox] and run `devbox shell`

[Install devbox]: https://www.jetpack.io/devbox/docs/installing_devbox/
# Issue

The required version of the concourse CLI is dictated by the server.
concourse.app-runtime-interfaces.ci.cloudfoundry.org is on 7.10.0

# Fix

Rollback and disable automated updates through renovate
Copy link

sonarqubecloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@silvestre silvestre added exclude-from-changelog dependencies Pull requests that update a dependency file labels May 3, 2024
@silvestre silvestre marked this pull request as ready for review May 3, 2024 11:46
@silvestre silvestre merged commit 7dbf585 into main May 3, 2024
38 of 41 checks passed
@silvestre silvestre deleted the devbox branch May 3, 2024 13:18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to test first, if the devbox-binary is available and only then do that eval. Similarly as it has been before.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point: #2921

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that file needed here for devbox? Can we avoid double-maintenance of those two packages?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, right. I hope it is possible to reuse this local-flake from the top-level flake?

Maybe you know how? 😄

If not I'll check.

bonzofenix pushed a commit that referenced this pull request May 21, 2024
# Issue

Specifying exact versions for dependencies in Nix is not
straightforward.

# Fix

This commit adds a basic `devbox` configuration for our project.

If you want to try it out:  [Install devbox] and run `devbox shell`

[Install devbox]: https://www.jetpack.io/devbox/docs/installing_devbox/

* fix(deps): Rollback `concourse` version

# Issue

The required version of the concourse CLI is dictated by the server.
concourse.app-runtime-interfaces.ci.cloudfoundry.org is on 7.10.0

# Fix

Rollback and disable automated updates through renovate

* 🤖🦾🛠️ scripts/asdf2devbox.py
bonzofenix pushed a commit that referenced this pull request May 21, 2024
Specifying exact versions for dependencies in Nix is not
straightforward.

This commit adds a basic `devbox` configuration for our project.

If you want to try it out:  [Install devbox] and run `devbox shell`

[Install devbox]: https://www.jetpack.io/devbox/docs/installing_devbox/

* fix(deps): Rollback `concourse` version

The required version of the concourse CLI is dictated by the server.
concourse.app-runtime-interfaces.ci.cloudfoundry.org is on 7.10.0

Rollback and disable automated updates through renovate

* 🤖🦾🛠️ scripts/asdf2devbox.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file exclude-from-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants