-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: refactoring methods in tests and adding tests for plugins #1346
Open
omgoswami
wants to merge
18
commits into
cloud-ark:master
Choose a base branch
from
omgoswami:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 17 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a615134
bulk application upgrade testcase
omgoswami 2573031
added automatic provider copy for testcase
omgoswami 568a593
removed pycache and adjusted req.txt
omgoswami 3af93a4
added tests dir requirements.txt and installed lxml in pr.yaml
omgoswami 7d0e88e
removed select from tests/requirements.txt
omgoswami 7019610
added lxml back into req.txt
omgoswami 6eb2a30
Merge branch 'cloud-ark:master' into master
omgoswami fbb8041
added kubectl appstatus plugin
omgoswami 2401905
Merge branch 'cloud-ark:master' into master
omgoswami 89a5efd
added appstatus plugin testcase & instance validation check in crmetrics
omgoswami df8a6d9
removed provider file & web token from tests/hello-world
omgoswami ffd6500
appresources working fine, cleaned up appstatus file
omgoswami 9ed594c
merged prof. kulkarni's changes, added asserts, and incorporated sugg…
omgoswami 76dfbca
removed comments & tests/hello-world, and restored hs1.yaml
omgoswami 414220a
switched chart reference in tests.py for appstatus test
omgoswami acc7c89
Merge branch 'master' of https://github.com/omgoswami/kubeplus
omgoswami 8b6baea
refactored setup/cleanup methods for hello-world example
omgoswami fddcca0
added appresources test
omgoswami File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need 'provider=provider', since provider is not a keyword argument in line 50.
Just pass provider.