Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: refactoring methods in tests and adding tests for plugins #1346

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

omgoswami
Copy link
Contributor

refactored setup and cleanup methods for testing with examples/hello-world
adding test cases for kubectl connections, appresources, appurl, applogs, and metrics

tests/tests.py Outdated
# register HelloWorldService API
cmd = "kubectl create -f ../examples/multitenancy/hello-world/hello-world-service-composition-localchart.yaml --kubeconfig=%s" % provider
TestKubePlus.run_command(cmd)
self.setup_example_hello_world(provider=provider)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need 'provider=provider', since provider is not a keyword argument in line 50.
Just pass provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants