Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade licensee #549

Merged
merged 6 commits into from
Jun 12, 2024
Merged

Conversation

yashkohli88
Copy link
Contributor

@yashkohli88 yashkohli88 commented Jan 31, 2024

Updated Dockerfile and DevDockerfile in order to update licensee which is one of the scanning tool that crawler uses from version 9.12.0 to 9.16.1. Ruby is also updated from 2.5.4 to 3.2.2. Details for this update can be found https://github.com/clearlydefined/crawler/issues/536

@lumaxis lumaxis changed the title Licensee-upgrade #536 Upgrade licensee Jan 31, 2024
@qtomlinson
Copy link
Collaborator

Task: #536

@yashkohli88 yashkohli88 marked this pull request as ready for review February 20, 2024 16:56
@yashkohli88 yashkohli88 marked this pull request as draft February 21, 2024 06:29
@yashkohli88 yashkohli88 marked this pull request as ready for review February 21, 2024 06:34
Copy link
Collaborator

@elrayle elrayle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great to see another dependency updated. Thanks for the very thorough analysis.

@elrayle
Copy link
Collaborator

elrayle commented Jun 7, 2024

@yashkohli88 @qtomlinson This looks ready to merge. Any reason to hold off?

@qtomlinson
Copy link
Collaborator

qtomlinson commented Jun 10, 2024

@elrayle Upon merging of the PR, integration tests need to be upgraded to prevent failure. This is work to be reviewed: clearlydefined/operations#80

@qtomlinson qtomlinson merged commit 88fe13f into clearlydefined:master Jun 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants